-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(account): keep all accounts in memory #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
Alex6323
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
Alex6323
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
zesterer
reviewed
Dec 16, 2020
Alex6323
reviewed
Dec 16, 2020
Alex6323
reviewed
Dec 16, 2020
Next steps (separate PRs):
|
zesterer
reviewed
Dec 18, 2020
zesterer
reviewed
Dec 18, 2020
zesterer
reviewed
Dec 18, 2020
zesterer
reviewed
Dec 18, 2020
zesterer
reviewed
Dec 18, 2020
zesterer
approved these changes
Dec 18, 2020
rajivshah3
approved these changes
Dec 18, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Instead of loading the account from storage and saving on each operation, we'll keep the account references stored on the AccountManager struct, wrapped on Arc<RwLock<>> for thread safety. This prevents race conditions between e.g. the polling system and the transfer API, where account data can be lost.
Type of change
How the change has been tested
Unit tests + faucet.
Change checklist